Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version number format to be Scala Steward friendly #46

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

SethTisue
Copy link
Member

fixes #45

@SethTisue
Copy link
Member Author

SethTisue commented Apr 26, 2023

if I understand correctly, it's expected that PR validation fails:

[error] sbt.librarymanagement.ResolveException: Error downloading org.scala-lang:scala-library:2.11.4-93-72f0796b

because it isn't doing export version=2.13.11-bin-d193135 scala_sha=d1931352941e5cca75c6afec1813192ec4283775 or similar before running

so I'm going to go ahead and merge this, and I'll be sure and check the next nightly run to make sure everything is still ok

@SethTisue SethTisue merged commit 3cf3dd9 into scala:2.13.x Apr 26, 2023
@SethTisue SethTisue deleted the fix-scala-steward branch April 26, 2023 23:34
@SethTisue
Copy link
Member Author

hmm, this also regressed the merge build. that's not okay. I'll send a followup PR

SethTisue added a commit that referenced this pull request Apr 27, 2023
@SethTisue
Copy link
Member Author

d5afcba straight up reverts this while I consider my next move

@SethTisue
Copy link
Member Author

instead: #47

@som-snytt
Copy link

also the issue should be labeled friendliness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala Steward not working in this repo?
2 participants