Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allowOrDefault in UpdatesConfig.isAllowed #3546

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 16, 2025

I forgot to update this reference in #3515. This is a subtle change in semantics. If allow == Some(Nil) allow.isEmpty is false and allowOrDefault.isEmpty is true.

I forgot to update this reference in #3515. This is a subtle change in semantics. If `allow == Some(Nil)`  `allow.isEmpty` is `false` and `allowOrDefault.isEmpty` is `true`.
@fthomas fthomas added bug Something isn't working cat:repo-config labels Jan 16, 2025
@fthomas fthomas added this to the 0.33.0 milestone Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (6e03c92) to head (863d071).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3546   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files         171      171           
  Lines        4989     4989           
  Branches      495      496    +1     
=======================================
  Hits         4481     4481           
  Misses        508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharp eyes 👍

@fthomas
Copy link
Member Author

fthomas commented Jan 16, 2025

Sharp eyes

Guess who looked at Scala Steward logs this morning and wondered why Scala updates where logged with Ignore org.scala-lang:scala-library : 2.13.15 -> 2.13.16 (reason: not allowed by config) without any such config in sight. :-)

@fthomas fthomas merged commit 5b13f31 into main Jan 16, 2025
18 checks passed
@fthomas fthomas deleted the fix/use-allowOrDefault branch January 16, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cat:repo-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants