Fixed action hyperlinking in route files when route definition starts wi... #130
Conversation
… with '@'. Changed action's regular expressions to account for optional starting '@' character. When searching for the method, if there does not exist a matching method on a module that matches the route action type name, then do a corresponding search for the method over classes. Fix scala-ide#119
|
PLS REBUILD/play2-3.0-e37-pr-validator (Really funky error, and looking at the Jenkins Job, tests have been failing since the 24th of May... Anyhow, before investing too much energy, let's see if wiping out the Job's workspace helps) |
|
Also because this branch builds perfectly fine on my machine... |
|
(kitty-note-to-self: ignore 18613930) |
|
NOLITTER! PLS REBUILD ALL! |
|
(kitty-note-to-self: ignore 18620202) |
|
(kitty-note-to-self: ignore 18620202) |
|
@adriaanm, I wonder if there's a bug in the kitty now.. it is looking at the wrong build: the kitty started building |
|
We can ignore the build failures, the correct build run is https://jenkins.scala-ide.org:8496/jenkins/job/play2-3.0-e37-pr-validator/164/, and that succeeded. |
| @@ -44,7 +44,13 @@ object RouteHyperlinkComputer { | |||
| val obj = rootMirror.getModuleIfDefined(routeAction.typeName) | |||
|
|
|||
| // method or methods of the object with the given name | |||
| val method = obj.info.member(newTermName(routeAction.methodName)) | |||
| val objMethod = obj.info.member(newTermName(routeAction.methodName)) | |||
There was a problem hiding this comment.
I don't think this would actually happen too often, but this would hyperlink to an object method if there is one, even if the route file uses @. Why not distinguish the two cases by the @ sign, and do just one query in the compiler, either in the object or in the class?
There was a problem hiding this comment.
You are right about that. I created another issue ticket earlier today (#131) for just this issue (per Mirco's suggestion).
yep, that looks like a bug -- I'll have a look at the logs if I can figure out what's going on PLS SYNCH |
|
(kitty-note-to-self: ignore 18630330) |
|
I think I know what the problem is: typesafehub/ghpullrequest-validator#40 |
|
Great work! LGTM! |
|
yeap, all good on this side, @adriaanm. Thanks for the quick fix! |
…th-@-#119 Fixed action hyperlinking in route files when route definition starts wi...
...th '@'.
Changed action's regular expressions to account for optional starting '@' character.
When searching for the method, if there does not exist a matching method on a module that matches the route action type name, then do a corresponding search for the method over classes.
Fix #119