Improved error message and FP style #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved error message. Improved style according to FP: (a) if-else made into expression for clarity (b) formatting
| lazy val initialVcsChecks = (st: State) => | ||
| if ((vcs(st).status !!).trim.nonEmpty) | ||
| sys.error("Aborting release. Working directory has uncommitted changes, " + | ||
| "please commit your changes before running this command.") |
There was a problem hiding this comment.
user can also stash or revert. committing is just one way to solve it
also i remember there were talks about allowing release to continue even wit dirty wd when some setting is set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved error message. Improved style according to FP: (a) if-else made into expression for clarity (b) formatting