Unified interface for setting random seed #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junya-takayama
requested changes
Nov 6, 2025
| logger.info(f"random seed: {random_seed}") | ||
| transformers.set_seed(random_seed) | ||
|
|
||
| def set_random_seed(self, seed: int) -> None: |
Collaborator
There was a problem hiding this comment.
Could you also add a test case for hf_lm.py?
Collaborator
Author
There was a problem hiding this comment.
Sorry, it was my oversight.
Added tests in e1cb5aa
Merged
butsugiri
force-pushed
the
random-seed
branch
from
eb5871f to
d7a05ae
Compare
Collaborator
Author
|
Rebased to include the changes in #255 |
Collaborator
Author
|
@junya-takayama CI looks OK now. Can you take another look, please? Thanks! |
junya-takayama
approved these changes
Nov 7, 2025
Collaborator
junya-takayama
left a comment
junya-takayama
left a comment
There was a problem hiding this comment.
Thanks for the fix. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the means of setting random seed is different across different language models.
For example:
This PR attempts to address this somewhat confusing behavior, by implementing
set_random_seedmethod