-
Notifications
You must be signed in to change notification settings - Fork 19
v2: merge to MTEB's codebase #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[dev to main] v1.4.0
README.md
Outdated
| | Feature | v1.x | v2.0 | | ||
| |---------|------|------| | ||
| | Evaluation Engine | Custom | MTEB | | ||
| | API Complexity | High | Low | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API Complexity は主観的な評価かなと思います
この行はなくても良いかと思いました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
削除しました。
README.md
Outdated
| | Evaluation Engine | Custom | MTEB | | ||
| | API Complexity | High | Low | | ||
| | Dataset Count | 28 | 28 | | ||
| | Caching | Basic | Advanced | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caching がどのようにAdvancedなのかを説明いただけると幸いです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cachingは1.xでは手動でのsaveでして,2.0はmtebのcaching機能をそのまま使えるのでより完備しているという意味で,この行なくてもいいので削除しました。
akiFQC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
関連する Issue / PR
N/A
PR をマージした後の挙動の変化
v2.0.0にアップグレード (詳細はREADMEに参照)
挙動の変更を達成するために行ったこと
動作確認