[Feature] JMTEB v2リリースに伴うリーダーボード更新&対応モデル追加 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiFQC
approved these changes
Nov 10, 2025
Collaborator
akiFQC
left a comment
akiFQC
left a comment
There was a problem hiding this comment.
超大作ですね！！おつかれさまでした！LGTMです！！
akiFQC
reviewed
Nov 10, 2025
| # Auto-optimize for PlamoEmbedder if no explicit kwargs provided | ||
| encode_kwargs = self.encode_kwargs.copy() | ||
|
|
||
| # Check if this is a PlamoEmbedder and set optimal encoding mode |
Collaborator
There was a problem hiding this comment.
[NIT] この処理が複数出てくるので、どこかにまとめてしまってもいいかもしれないですね。
Collaborator
Author
There was a problem hiding this comment.
それぞれのタスクにそれぞれの処理があるのでこのままでも良いかなと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連する Issue / PR
#83
PR をマージした後の挙動の変化
jmteb.jsonnetを更新し，更新版JMTEBを回せるようにしました。JMTEBの更新履歴はhttps://huggingface.co/datasets/sbintuitions/JMTEB/blob/main/UPDATES.md をご参照ください。
今回は
合わせてリーダーボードも更新しました。
plamo-embedding, embeddinggemmaとBAAI/bge-m3を回せるようにそれぞれのembedderを追加しました。
データセットごとに最大トークン長を設定できるようにしました。
挙動の変更を達成するために行ったこと
src/jmteb/configs/tasksにデータセットの追加・削除src/jmteb/configs/jmteb.jsonnetの変更src/jmteb/embeddersにplamoとembeddinggemma用のembedderを追加動作確認