Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk update fix for foreign keys #221

Closed
wants to merge 1 commit into from
Closed

Bulk update fix for foreign keys #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions src/adminactions/bulk_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import csv
import logging
import os
import tempfile
from pathlib import Path
from typing import Dict, Optional, Sequence

from django import forms
from django.contrib import messages
from django.contrib.admin import helpers
from django.core.exceptions import ValidationError
from django.core.exceptions import ObjectDoesNotExist, ValidationError
from django.core.validators import FileExtensionValidator
from django.db.transaction import atomic
from django.forms import Media
Expand Down Expand Up @@ -119,7 +121,7 @@ def get_mapping(self):
def bulk_update(modeladmin, request, queryset): # noqa
try:
opts = modeladmin.model._meta
perm = "{0}.{1}".format(
perm = "{}.{}".format(
opts.app_label, get_permission_codename(bulk_update.base_permission, opts)
)
bulk_update_form = getattr(modeladmin, "bulk_update_form", BulkUpdateForm)
Expand Down Expand Up @@ -177,9 +179,12 @@ def bulk_update(modeladmin, request, queryset): # noqa
# use_celery = form.cleaned_data.get("_async", False)
try:
f = form.cleaned_data.pop("_file")
temp_file = tempfile.NamedTemporaryFile(delete=False, suffix=".csv")
temp_file.write(f.read())
temp_file.close()
res = _bulk_update(
queryset,
f.file.name,
temp_file.name,
mapping=map_form.get_mapping(),
header=header,
clean=clean,
Expand All @@ -201,6 +206,8 @@ def bulk_update(modeladmin, request, queryset): # noqa
return HttpResponseRedirect(request.get_full_path())
else:
return HttpResponseRedirect(request.get_full_path())
finally:
os.unlink(temp_file.name)
else:
form = bulk_update_form(initial=form_initial)
csv_form = CSVConfigForm(initial=csv_initial, prefix="csv")
Expand Down Expand Up @@ -267,8 +274,10 @@ def _bulk_update( # noqa: max-complexity: 18
try:
with Path(filename).open("r") as f:
if header:
reader = csv.DictReader(f.readlines(), **(csv_options or {}))
for k, v in mapping.items():
reader = csv.DictReader(
f.readlines(), skipinitialspace=True, **(csv_options or {})
)
for _k, v in mapping.items():
if v not in reader.fieldnames:
raise ValidationError(
_("%s column is not present in the file") % v
Expand All @@ -293,6 +302,25 @@ def _bulk_update( # noqa: max-complexity: 18
if i in reverse.keys():
field = reverse[i]
if field not in indexes:
model_field = queryset.model._meta.get_field(
field
)
if (
model_field.is_relation
and model_field.many_to_one
):
related_model = model_field.related_model
try:
value = related_model.objects.get(
pk=value
)
except ObjectDoesNotExist:
raise ValidationError(
"No {} found with id {}".format(
related_model._meta.verbose_name,
value,
)
)
setattr(obj, field, value)
if clean:
obj.clean()
Expand Down
Loading