Skip to content

Conversation

@rehsfl
Copy link
Contributor

@rehsfl rehsfl commented Aug 21, 2025

Changes proposed in this pull request:

  • Implement a loading bar in the frontend
  • Optimize certain functions handling json files to reduce loading times
  • Put in place a checksum verification to avoid validation of unchanged input files

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

  • Start vulnscout and ovserve the loading bar in the web dashboard, take note of processing time
  • Stop and restart vulnscout with the same input files, notice the validation is skipped

Pull Request Checklist

Please review and check all that apply before submitting your PR:

  • The code compiles and passes all tests
  • All new and existing tests are passing
  • Documentation has been updated (if applicable)
  • Code follows project style guidelines
  • No sensitive information is included
  • Linked relevant issues (if any)
  • Added necessary reviewers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's weird to have "set_status" with a parameter progress to 0 for every task.

Should create two fonctions : set_status which set progress to 0 and update_progress to modify the progression

Or set a default parameter to 0 at set_status.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress value is an optional attribute. For example in Step 4: scanning spdx / cdx with Grype, we do not have a progress value at all.

You suggest to set progress to 0 inside set_status, which means we assume all tasks have a progress bar, which is not always true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you have a single function that handles lossing bar creation/or not and used to modify the value of the progress.
Maybe create multiples fonctions (init_loading_bar, set_loading_value). Would be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the same function to set status, it's simply a value that is appended to the status.txt each time the event / progression changes. There is no need to create additional functions and possibly other temporary file to only handle progress bar

@ValentinBoudevin
Copy link
Contributor

Step 7/7 : Exporting CycloneDX file

I don't use a CycloneDX file (with SPDX3 example). I should not have this message displayed

@ValentinBoudevin
Copy link
Contributor

TO BE MERGE AFTER v0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants