-
Notifications
You must be signed in to change notification settings - Fork 11
Improve app loading process #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's weird to have "set_status" with a parameter progress to 0 for every task.
Should create two fonctions : set_status which set progress to 0 and update_progress to modify the progression
Or set a default parameter to 0 at set_status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress value is an optional attribute. For example in Step 4: scanning spdx / cdx with Grype, we do not have a progress value at all.
You suggest to set progress to 0 inside set_status, which means we assume all tasks have a progress bar, which is not always true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you have a single function that handles lossing bar creation/or not and used to modify the value of the progress.
Maybe create multiples fonctions (init_loading_bar, set_loading_value). Would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the same function to set status, it's simply a value that is appended to the status.txt each time the event / progression changes. There is no need to create additional functions and possibly other temporary file to only handle progress bar
|
Step 7/7 : Exporting CycloneDX file I don't use a CycloneDX file (with SPDX3 example). I should not have this message displayed |
|
TO BE MERGE AFTER v0.8.1 |
Changes proposed in this pull request:
Status
How to verify this change
Pull Request Checklist
Please review and check all that apply before submitting your PR: