Skip to content

Conversation

@rehsfl
Copy link
Contributor

@rehsfl rehsfl commented Oct 17, 2025

Changes proposed in this pull request:

  • Change status string (Not affected, fixed, ...) to ensure capitalization is consistent across the app

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Open the web dashboard and notice status naming is consistent across the app, including in graphs and assessments

Pull Request Checklist

Please review and check all that apply before submitting your PR:

  • The code compiles and passes all tests
  • All new and existing tests are passing
  • Documentation has been updated (if applicable)
  • Code follows project style guidelines
  • No sensitive information is included
  • Linked relevant issues (if any)
  • Added necessary reviewers

@ValentinBoudevin
Copy link
Contributor

LGTM but squash tests in your commit + add a description

- Modify VEX assessments labels in frontend to have a consistant
naming scheme, as the labels had inconsistant capitalization
- Update tests
@rehsfl rehsfl force-pushed the status-string-capitalization branch from 9f2aa60 to fc9b80d Compare October 23, 2025 15:21
Copy link
Contributor

@ValentinBoudevin ValentinBoudevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValentinBoudevin ValentinBoudevin merged commit 9296e2b into savoirfairelinux:staging Oct 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants