Skip to content

Conversation

@rehsfl
Copy link
Contributor

@rehsfl rehsfl commented Sep 25, 2025

Changes proposed in this pull request:

  • Create an SPDX3 class to construct an SPDX3 JSON document
  • Add SPDX3 format to merger_ci so it appears in the output folder
  • Add an export option in the Export view of the web dashboard

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Launch VS (either in SPDX2/3 modes) then:

  • Verify that an SPDX3 JSON file is present in the output folder
  • Open the web dashboard, then export an SPDX3 JSON file

Pull Request Checklist

Please review and check all that apply before submitting your PR:

  • The code compiles and passes all tests
  • All new and existing tests are passing
  • Documentation has been updated (if applicable)
  • Code follows project style guidelines
  • No sensitive information is included
  • Linked relevant issues (if any)
  • Added necessary reviewers

@rehsfl rehsfl marked this pull request as draft October 8, 2025 15:25
@rehsfl rehsfl marked this pull request as ready for review October 16, 2025 14:21
@rehsfl rehsfl changed the base branch from main to staging October 16, 2025 14:25
@rehsfl rehsfl changed the title SPDX3 nerge and export Generate and export SPDX3 outputs Oct 16, 2025
@ValentinBoudevin
Copy link
Contributor

LGTM, great feature. It even work converting a old SPDX2 to modern SPDX3.
Can you add a description in your commits?

Copy link
Contributor

@ValentinBoudevin ValentinBoudevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but next time we will need to do cleaner commits with description.

@ValentinBoudevin ValentinBoudevin merged commit f10724e into savoirfairelinux:staging Oct 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants