Skip to content

Chapter 6/sql_store*/store.go: always defer rows.Close() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Chapter 6/sql_store*/store.go: always defer rows.Close() #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chapter_6_Storing_Data/sql_store1/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ func Posts(limit int) (posts []Post, err error) {
if err != nil {
return
}
defer rows.Close()
for rows.Next() {
post := Post{}
err = rows.Scan(&post.Id, &post.Content, &post.Author)
Expand All @@ -37,7 +38,6 @@ func Posts(limit int) (posts []Post, err error) {
}
posts = append(posts, post)
}
rows.Close()
return
}

Expand Down
2 changes: 1 addition & 1 deletion Chapter_6_Storing_Data/sql_store2/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func GetPost(id int) (post Post, err error) {
if err != nil {
return
}
defer rows.Close()
for rows.Next() {
comment := Comment{Post: &post}
err = rows.Scan(&comment.Id, &comment.Content, &comment.Author)
Expand All @@ -59,7 +60,6 @@ func GetPost(id int) (post Post, err error) {
}
post.Comments = append(post.Comments, comment)
}
rows.Close()
return
}

Expand Down