fix(constants): correct and unify constant implementations across files

[satnam72]

Description

• Removed redundant prefixes in constant keys for better clarity and maintainability
• Clarified usage instructions for constants and configuration
• Fixed issue with dynamically added draggable elements in demo
• Updated version text on demo page to reflect current version

Related Issue

• Closes Replace magic numbers with named constants #20

Type of Change

• Bug fix
• Refactoring

How Has This Been Tested?

By running the local sever and npm run test

Checklist

• My code follows the project’s style guidelines
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Additional Notes

N/A

Summary by CodeRabbit

• Refactor
  • Simplified configuration constants, introduced explicit stack-direction options and reduced some z-index values; removed obsolete constant entries (may affect direct references).
• Bug Fixes
  • Improved visual layering when a dragged item returns to the play area for more consistent stacking.
• Documentation
  • Updated docs and examples to use literal CSS selectors and removed example event-listener snippets.
• Chores
  • Demo now shows the updated version string.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Updated documentation and demo usage to use literal class selectors; slimmed and renamed constants (Z_INDEX values reduced, STACK_DIRECTION enum added); core logic changes: per-element event unbinding moved inside update loop and returned-to-play-area z-index set to DRAGGING.

Changes

Cohort / File(s)	Summary
Docs: usage samples README.md, docs/allonsh.md	Removed import of constants and example event listeners; selector examples changed from constant references to literal class strings.
Demo: version text demo/index.html	Updated displayed version from v0.1.0-beta2 to v0.2.0-beta.
Constants: API adjustments src/constants.js, docs/constants.md	Z_INDEX reduced to only GHOST: 99 and DRAGGING: 100; removed other Z_INDEX entries; DEFAULTS trimmed (kept STACK_SPACING, STACK_DIRECTION); added STACK_DIRECTION = { VERTICAL, HORIZONTAL }; docs updated accordingly.
Core logic: stacking and event handling src/allonsh.js	Imported STACK_DIRECTION; used it for stacking flex direction; moved _unbindEventListeners() call inside per-draggable loop in update(); _handleDrop now sets z-index to Z_INDEX.DRAGGING when returning to play area.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Draggable
  participant Allonsh
  participant Dropzone
  participant PlayArea

  rect rgba(230,240,255,0.6)
  note right of Allonsh: update() cycle (changed)
  Allonsh->>Allonsh: update()
  loop for each draggable
    Allonsh->>Draggable: _unbindEventListeners()  (moved inside loop)
    Allonsh->>Draggable: _bindEventListeners()
  end
  end

  User->>Draggable: drag
  Allonsh->>Draggable: set z-index = Z_INDEX.DRAGGING
  User->>Dropzone: drop?
  alt Dropped in dropzone
    Allonsh->>Dropzone: place element
    Allonsh->>Draggable: apply stacking styles (STACK_DIRECTION, spacing)
  else Not in dropzone
    Allonsh->>PlayArea: return element
    note over Allonsh,Draggable: z-index on return changed
    Allonsh->>Draggable: set z-index = Z_INDEX.DRAGGING (was DROPPED)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Z-index values replaced with named constants (GHOST, DRAGGING) and magic numbers removed where applicable (#20)	✅
DEFAULTS exposed with STACK_SPACING and STACK_DIRECTION definitions (#20)	✅
Provide CSS_CLASSES object with consistent class names; remove hardcoded CSS class names (#20)	❌	Docs and README now use literal strings instead of introducing/using a CSS_CLASSES constant.

Assessment against linked issues: Out-of-scope changes

Code Change	Explanation
Move _unbindEventListeners() into per-element loop in update() (src/allonsh.js)	Alters event lifecycle and performance; not part of replacing magic numbers or introducing constants.
Change returned-to-play-area z-index to Z_INDEX.DRAGGING (src/allonsh.js, _handleDrop)	Functional behavior change for drop handling; unrelated to constants replacement objective.
Replaced constant-based selectors with literal class strings in docs (README.md, docs/allonsh.md)	Instead of centralizing class names into CSS_CLASSES, docs now use literals, which runs counter to the "replace hardcoded values with named constants" objective.

Poem

I hop through lines with nimble paws,
Swapping numbers for named applause.
A stack, a drift, a z-index song—
I tidy constants all day long.
Version bumped, I nibble on bugs. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e69f23 and 1a6a3e4.

📒 Files selected for processing (6)

• README.md (1 hunks)
• demo/index.html (1 hunks)
• docs/allonsh.md (1 hunks)
• docs/constants.md (1 hunks)
• src/allonsh.js (4 hunks)
• src/constants.js (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/constants

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[satnam72]

@CodeRabbit full review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

✅ Actions performed

Full review triggered.