Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stroke.size parameter DimPlot #8180

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

samuel-marsh
Copy link
Collaborator

Hi Seurat Team,

This is PR to address #7087. This adds the stroke.size parameter to DimPlot and consequently SingleDimPlot. The parameter is set to NULL by default. When this is the case the stroke.size is set to static value which appears to be default ggplot2 value. I tested the plotting with this value of stroke.size vs. current DimPlot and the plots appeared identical to me.

Best,
Sam

@samuel-marsh
Copy link
Collaborator Author

Hi @dcollins15,

Here is quick PR I thought I would ping. Adds single parameter to DimPlot. I just rebased branch but let me know if there is anything else you need me to do!

Best,
Sam

Copy link
Contributor

@dcollins15 dcollins15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solid one—thanks @samuel-marsh 👍

@dcollins15 dcollins15 merged commit 0c2b035 into satijalab:develop Dec 20, 2024
2 checks passed
@dcollins15 dcollins15 mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants