[Slash Separator] Parse / as a separator rather than a division operator
#2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2025
nex3
force-pushed
the
slash-div
branch
4 times, most recently
from
3aa3f08 to
5b9fe7c
Compare
jathak
reviewed
Sep 19, 2025
| if (i != 0) { | ||
| if (!lastElementEmpty) { | ||
| _buffer.writeCharCode($space); | ||
| lastElementEmpty = false; |
There was a problem hiding this comment.
I'm not quite following this code. Once lastElementEmpty is set to true, it would never be set back to false, since the only place its set is inside this if that only executes when lastElementEmpty is already false.
Is this line supposed to be somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #663
See sass/sass#4131
See sass/sass-spec#2086