Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F rating #1

Merged
merged 38 commits into from
Apr 27, 2019
Merged

F rating #1

merged 38 commits into from
Apr 27, 2019

Conversation

saran2020
Copy link
Owner

Base Impl of the Slide Rating View

saran2020 added 30 commits April 7, 2019 02:41
@saran2020
Added three assts required for star
0300f6d
@saran2020
Added a basic SlideRating View and files related to it
3645c7b
@saran2020
Removed dependency of constrain layout
7ffff68
@saran2020
Setup the main activity to show the rating view
2ea7b1c
@saran2020
Added some more safety check as required
80fbea1
@saran2020
Fixed the logic of setting the rating view's asset
375f67d
@saran2020
Made the space between rating to be shown when set or passed in xml
c28591f
@saran2020
Added a on click listener to the rating view
62b6e3e
@saran2020
Base impl of the the drag of view
3218b00
@saran2020
Upde the gradle wrapper to new supported version by android plugin
e135b6a
@saran2020
Update the android plugin to version 3.4.0
ed48ec9
@saran2020
Add logic to track touch and calculate current rating
0554f66
@saran2020
Add logic to round of rating to the closet allowed rating based on tr…
2d32b40 
…acking of touch
@saran2020
Remove setting of tag to the view, no longer required
99b7c22
@saran2020
Made add view function 0 based instead of 1 based
350085a
@saran2020
Fix the logic of set rating asset, setting incorrect asset
cef2fd6
@saran2020
Add a todo to make the assetmap drawable based instead of drawable res
72efc9c
@saran2020
Add new interface to pass on the callback when rating is changed
d5b1dcc
@saran2020
Change the logic of set currentRating method to use the callback and …
cb13a07 
…also some efficiency improvement. I guess
@saran2020
Moved some constants to String.xml
c8ab12f
@saran2020
Made the Main activity to use callback to set the values
cc52e83
@saran2020
Changed the access modifier to match the requirement
88eba39
@saran2020
Add a new module sliderating
7e35175
@saran2020
Remove all the testing related code auto added
e69bb35
@saran2020
Refactor the file string.xml to values.xml, because there isn't much …
0aebbee 
…going to be in there
@saran2020
Remove the "libs" directory dependency from the app module
529927a
@saran2020
Add sliderating (new module) dependency to the the app module
f4c927b
@saran2020
Move the attr from app module to the library module
ef0540f
@saran2020
Add kotlin dependency to the library module
0c1c6f7
@saran2020
Update the kotlin dependency version to 1.3.30 from 1.3.21
42017bf
@saran2020 saran2020 merged commit ae26ffa into master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saran2020