Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ❌ | rawdata not moved to data/raw |
| Part 1 - Q3 | ❌ | ls command not run |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | Missing files in data/processed/server_logs |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed. |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
…sed/user_logs/ that contain ipaddr anywhere in the filename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Updated assignment.sh to complete assignment 1.
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
My first attempt at the assignment was during the live coding session. I worked on a few of the questions and pushed changes ahead of where the class was. I was unable to clarify what I should do quickly enough so I "solved" my problem by nuking the repo and starting over bc I didn't want to fall behind in class. Nuking it, dear reader, caused me to fall behind in class. In retrospect, it would have been fine, but I'm new to git so ¯\_(ツ)_/¯
How were these changes tested?
Tested all changes in zsh before pushing changes to assignment branch.
A reference to a related issue in your repository (if applicable)
Unclear what this means.
Checklist