fix: make sure sonar only runs if sonar_token is set

sapphiredev · Sep 24, 2024 · 0bb9d34 · 0bb9d34
1 parent 82ca8fe
commit 0bb9d34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/reusable-sonar.yml b/.github/workflows/reusable-sonar.yml
@@ -27,7 +27,7 @@ jobs:
   sonar:
     name: Sonar Analysis
     runs-on: ${{ inputs.operating-system }}
-    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == 'sapphiredev'
+    if: (github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == 'sapphiredev') && github.actor != 'dependabot[bot]'
     steps:
       - name: Checkout Project
         uses: actions/checkout@v4
@@ -39,7 +39,6 @@ jobs:
         with:
           node-version: ${{ inputs.node-version }}
       - name: SonarCloud Scan
-        if: env.SONAR_TOKEN
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/.github/workflows/reusable-tests.yml b/.github/workflows/reusable-tests.yml
@@ -60,7 +60,7 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
       - name: SonarCloud Scan
-        if: inputs.enable-sonar && env.SONAR_TOKEN && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == 'sapphiredev')
+        if: inputs.enable-sonar && github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == 'sapphiredev')
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}