network: Add support for xmit_hash_policy (bsc#1033917) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the xmit_hash_policy property of NIC bonding to be queried and set, as well as adding the existing miimon property and new xmit_hash_policy property to the network schema. Add support for miimon to be set (or overloaded) on a per-network basis, like xmit_hash_policy. Drive-by correctly setting miimon rather than hardcoding 100 for the interfaces(5) template. (cherry picked from commit 08559ef) (cherry picked from commit d58f6dd)
houndci-bot
reviewed
Jun 28, 2017
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout Error: obsolete parameter AlignWith (for Lint/EndAlignment) found in .rubocop.yml `AlignWith` has been renamed to `EnforcedStyleAlignWith`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Backport of crowbar#1231 -- required for a partner.)
Add support for the xmit_hash_policy property of NIC bonding to be queried
and set, as well as adding the existing miimon property and new
xmit_hash_policy property to the network schema.
Add support for miimon to be set (or overloaded) on a per-network basis,
like xmit_hash_policy.
Drive-by correctly setting miimon rather than hardcoding 100 for the
interfaces(5) template.
(cherry picked from commit 08559ef)
(cherry picked from commit d58f6dd)