Start moving away from search queries to static config items for cookbooks #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this is to allow barclamps to export the relevant config bits to data bag items, so that nodes that are either not part of this proposal but need config from that barclamp or nodes that require info about other nodes in this proposal, can simply load the data bag item. We also cache the config to avoid loading it multiple times per run. This will help reduce the amount of search queries that are done from the clients to the chef server. (cherry picked from commit 7857fc8)
(cherry picked from commit 5845ff7)
(cherry picked from commit 5773887)
(cherry picked from commit f7e8ff5)
There are more uses of search queries for the provisioner-server node, but let's ignore that for now. (cherry picked from commit 8d9265f)
This will be used when we need to load the config from the rails app (to avoid looking at proposals). (cherry picked from commit be281af)
When no instance is specified and we can't detect which one to use, then
try with "default", and if that doesn't work, find the first instance
that has an applied proposal for this barclamp.
This makes it possible to do something like Config.load("openstack",
"nova") without having to care what's the instance of the applied nova
proposal -- which is okay because there's only one applied proposal for
that barclamp.
(cherry picked from commit b6405c3)
(cherry picked from commit 2e65b51)
On installation, the data bag configuration is created before the admin server gets allocated an IP address. So we need to deal with the case where the node may not have an admin network in the code. This also means we will need to regenerate the data bag configuration at some point; this will be done in the install script, after we move the admin server to hardware-installing. (cherry picked from commit 3963959)
This allows us to use attr_accessor. (cherry picked from commit e38e302)
(cherry picked from commit 0e5724a)
5 tasks
This will be used when updating barclamps to forcefully regenerate the configs, in order to avoid the need of reapplying a barclamp to get the matching data bag item. (cherry picked from commit 8a4fc7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of