Fix php 8.4 deprecated types #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@santigarcor Let me know if something else need to be provided for the PR. |
santigarcor
requested changes
Jan 15, 2025
src/Contracts/LaratrustUser.php
Outdated
| @@ -150,5 +150,5 @@ public function syncPermissions( | |||
| * | |||
| * @return Collection<\Laratrust\Contracts\Permission> | |||
| */ | |||
| public function allPermissions(array $columns = null, $team = false): Collection; | |||
| public function allPermissions(?array $columns = null, bool $team = false): Collection; | |||
There was a problem hiding this comment.
$team should be a mixed variable.
| @@ -498,7 +498,7 @@ public function syncPermissionsWithoutDetaching( | |||
| * | |||
| * @return Collection<\Laratrust\Contracts\Permission> | |||
| */ | |||
| public function allPermissions(array $columns = null, $team = false): Collection | |||
| public function allPermissions(?array $columns = null, bool $team = false): Collection | |||
There was a problem hiding this comment.
$team should be a mixed variable.
|
@incoming-th can you please add |
@santigarcor Sure, I totally forgot about this thanks. |
santigarcor
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the PHP 8.4 warning messages:
PHP Deprecated: Laratrust\Traits\HasRolesAndPermissions::allPermissions(): Implicitly marking parameter $columns as nullable is deprecated, the explicit nullable type must be used instead in /vendor/santigarcor/laratrust/src/Traits/HasRolesAndPermissions.php on line 501
PHP Deprecated: Laratrust\Contracts\LaratrustUser::allPermissions(): Implicitly marking parameter $columns as nullable is deprecated, the explicit nullable type must be used instead in /vendor/santigarcor/laratrust/src/Contracts/LaratrustUser.php on line 153