Repository navigation
Reduce compilation peak memory by 45% - #28
Merged
Merged
Conversation
Contributor
|
very cool, lets go! |
Contributor
|
maybe we should remove the |
Contributor
Author
|
Good call, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store single transitions inline in 12-byte automaton states (previously 32 bytes), preallocate dense transitions, and add memory measurements to
cmd/parse-bench.With
ecomscan.yar(26,782 rules), peak RSS drops 304 → 166 MiB (45% less). Across 6,210 real corpus files, median scan time is comparable (15.30 → 15.42 seconds), with 29,260 matches and no errors in every run.Validation: full test suite, race tests,
go vet, and the optional go-yara benchmark tests pass.