Removes unwrap #16
Open
Removes unwrap #16
+228
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koutheir
reviewed
Sep 28, 2021
koutheir
reviewed
Sep 28, 2021
koutheir
reviewed
Sep 28, 2021
koutheir
reviewed
Sep 28, 2021
| @@ -19,11 +19,11 @@ bitflags::bitflags! { | |||
| * | |||
| * Returns exit code program on success. | |||
| */ | |||
| pub fn run_command(payload: &mut std::os::raw::c_void) -> Result<i32, ()> { | |||
| pub fn run_command(payload: &mut std::os::raw::c_void) -> crate::Result<i32> { | |||
There was a problem hiding this comment.
Use a type alias for Result instead of typing crate::Result every time.
koutheir
reviewed
Sep 28, 2021
koutheir
reviewed
Sep 28, 2021
koutheir
reviewed
Sep 28, 2021
|
I left a few comments on the PR. I did not make an exhaustive review. |
sanpii
force-pushed
the
error
branch
3 times, most recently
from
65d3f70 to
f3d6594
Compare
sanpii
force-pushed
the
main
branch
16 times, most recently
from
e2f6647 to
36b51ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.