Skip to content

test: add process exit and safe chaining to notification smoke tests #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jadonamite wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add process exit and safe chaining to notification smoke tests #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions tests/notificationSystem.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ class NotificationSystemTest {
console.log('✅ Email service test passed\n');

console.log('🎉 All notification system tests passed!');

// FIX: Force process to exit cleanly. Without this, open DB/SMTP connections
// will keep the Node event loop running and the script will hang forever.
process.exit(0);

} catch (error) {
console.error('❌ Test failed:', error.message);
Expand Down Expand Up @@ -109,8 +113,10 @@ class NotificationSystemTest {

// Verify preferences were set
const savedPreferences = await this.notificationManager.getUserPreferences(testUserId);
if (!savedPreferences.email.transaction) {
throw new Error('User preferences not saved correctly');

// FIX: Added optional chaining to prevent TypeErrors if savedPreferences is null/undefined
if (!savedPreferences?.email?.transaction) {
throw new Error('User preferences not saved correctly or returned null');
}
}

Expand All @@ -131,7 +137,8 @@ class NotificationSystemTest {
txHash: '0x123456789'
});

if (!renderedEmail.includes('100.00')) {
// FIX: Added optional chaining just in case renderTemplate fails silently
if (!renderedEmail?.includes('100.00')) {
throw new Error('Email template rendering failed');
}
}
Expand All @@ -143,4 +150,4 @@ if (require.main === module) {
test.runTests().catch(console.error);
}

module.exports = NotificationSystemTest;
module.exports = NotificationSystemTest;