test: add missing assertions for setup blocks in analytics tests - #222
Open
jadonamite wants to merge 1 commit into
Open
test: add missing assertions for setup blocks in analytics tests#222jadonamite wants to merge 1 commit into
jadonamite wants to merge 1 commit into
Conversation
Updates the "tracks user activity" test to capture the mined setup block and actively assert that the record-deposit transaction succeeds before querying the read-only function. This is a critical testing practice to prevent silent failures during test setup from causing confusing downstream errors (like .expectSome() failing because the deposit never actually happened).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the "tracks user activity" test to capture the mined setup block and actively assert that the record-deposit transaction succeeds before querying the read-only function. This is a critical testing practice to prevent silent failures during test setup from causing confusing downstream errors (like .expectSome() failing because the deposit never actually happened).