-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update compiler warnings counter #8535
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Coverage Report
File CoverageNo changed files found. |
Component Testing Report Updated Feb 7, 2025 10:26 AM (UTC) ❌ Failed Tests (1) -- expand for details
|
⚡️ Editor Performance ReportUpdated Fri, 07 Feb 2025 10:31:46 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation, Cody! Looks good to me.
Description
#8513 fixed a react compiler bailout.
This bailout were flagged as invalid/unsafe react, having a
cachedSystemGroups = groups
assignment as a side-effect inside auseMemo
closure is dangerous and relies on internal React behaviour, which can change in a minor/patch version of React.The new code has a different bailout, it's not actionable though as the code is valid. The compiler is simply seeing that the memoization it creates looks different than the manual
useMemo
code, and so it bails out due to an abundance of caution. We can expect it to stop bailing out by the time the compiler reaches a stable release (it's currently in beta).What to review
Testing
I ran
pnpm check:react-compiler
and noted down the new count of warnings.Notes for release
N/A