Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): assign releases codeowners to studio-app #8532

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

assign releases codeowners to studio-app

What to review

Testing

Notes for release

n/a internal

@pedrobonamin pedrobonamin requested a review from a team as a code owner February 7, 2025 09:18
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team February 7, 2025 09:18
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:18am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:18am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:18am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 7, 2025 9:18am
test-next-studio ⬜️ Ignored (Inspect) Feb 7, 2025 9:18am

Copy link
Contributor

github-actions bot commented Feb 7, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.38% 53684 / 126654
🔵 Statements 42.38% 53684 / 126654
🔵 Functions 47.87% 2766 / 5777
🔵 Branches 78.79% 10281 / 13047
File CoverageNo changed files found.
Generated in workflow #29965 for commit 06fbdc3 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Component Testing Report Updated Feb 7, 2025 9:25 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 7, 2025

⚡️ Editor Performance Report

Updated Fri, 07 Feb 2025 09:27:19 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 24.4 efps (41ms) +0ms (-/-%)
article (body) 72.5 efps (14ms) 77.8 efps (13ms) -1ms (-/-%)
article (string inside object) 25.6 efps (39ms) 25.0 efps (40ms) +1ms (+2.6%)
article (string inside array) 22.2 efps (45ms) 22.0 efps (46ms) +1ms (+1.1%)
recipe (name) 41.7 efps (24ms) 47.6 efps (21ms) -3ms (-12.5%)
recipe (description) 47.6 efps (21ms) 51.3 efps (20ms) -2ms (-7.1%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.2 efps (55ms) 17.9 efps (56ms) +1ms (+1.8%)
synthetic (string inside object) 18.5 efps (54ms) 18.9 efps (53ms) -1ms (-1.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 44ms 47ms 360ms 237ms 10.4s
article (body) 14ms 17ms 25ms 220ms 317ms 5.7s
article (string inside object) 39ms 41ms 45ms 290ms 423ms 7.4s
article (string inside array) 45ms 47ms 52ms 158ms 271ms 7.1s
recipe (name) 24ms 25ms 27ms 57ms 0ms 8.9s
recipe (description) 21ms 23ms 25ms 62ms 0ms 5.3s
recipe (instructions) 5ms 6ms 7ms 8ms 0ms 3.0s
synthetic (title) 55ms 58ms 66ms 305ms 1064ms 13.3s
synthetic (string inside object) 54ms 57ms 69ms 415ms 1304ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 44ms 57ms 395ms 364ms 10.8s
article (body) 13ms 15ms 18ms 155ms 173ms 4.9s
article (string inside object) 40ms 42ms 52ms 239ms 301ms 7.2s
article (string inside array) 46ms 48ms 57ms 284ms 479ms 7.5s
recipe (name) 21ms 23ms 26ms 52ms 0ms 7.3s
recipe (description) 20ms 21ms 22ms 46ms 0ms 4.7s
recipe (instructions) 5ms 6ms 7ms 19ms 0ms 3.0s
synthetic (title) 56ms 60ms 75ms 437ms 1521ms 16.2s
synthetic (string inside object) 53ms 54ms 64ms 301ms 735ms 8.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin added this pull request to the merge queue Feb 7, 2025
Merged via the queue into next with commit 8e4ebe8 Feb 7, 2025
62 checks passed
@pedrobonamin pedrobonamin deleted the releases-codeowners branch February 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants