Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update plugin-mux dependency in test and studio-e2-testing #8520

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Feb 6, 2025

Description

Update version for the plugin-mux-video-input

2.2.1 -> 2.5.0

What to review

N/A

Testing

This update fixes an issue that is most easily seen the fix of if you:

  • So the the videos menu in the nav bar
  • When pressing it the videos will load, and not spin forever

Notes for release

N/A

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 1:24pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 1:24pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 1:24pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 1:24pm
test-next-studio ⬜️ Ignored (Inspect) Feb 7, 2025 1:24pm

Copy link
Contributor

github-actions bot commented Feb 6, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.45% 53812 / 126761
🔵 Statements 42.45% 53812 / 126761
🔵 Functions 47.94% 2772 / 5782
🔵 Branches 78.75% 10300 / 13078
File CoverageNo changed files found.
Generated in workflow #30005 for commit 1d78b55 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Component Testing Report Updated Feb 7, 2025 1:29 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 58s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 31s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 5s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 6, 2025

⚡️ Editor Performance Report

Updated Fri, 07 Feb 2025 13:30:45 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.8 efps (42ms) 25.6 efps (39ms) -3ms (-7.1%)
article (body) 72.2 efps (14ms) 73.0 efps (14ms) -0ms (-/-%)
article (string inside object) 27.0 efps (37ms) 26.3 efps (38ms) +1ms (+2.7%)
article (string inside array) 23.8 efps (42ms) 23.3 efps (43ms) +1ms (+2.4%)
recipe (name) 47.6 efps (21ms) 47.6 efps (21ms) +0ms (-/-%)
recipe (description) 51.3 efps (20ms) 52.6 efps (19ms) -1ms (-2.6%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.2 efps (55ms) 19.2 efps (52ms) -3ms (-5.5%)
synthetic (string inside object) 20.0 efps (50ms) 20.4 efps (49ms) -1ms (-2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 66ms 77ms 524ms 985ms 11.3s
article (body) 14ms 15ms 24ms 213ms 169ms 5.4s
article (string inside object) 37ms 38ms 44ms 168ms 267ms 7.0s
article (string inside array) 42ms 45ms 50ms 63ms 559ms 7.5s
recipe (name) 21ms 22ms 24ms 48ms 0ms 7.8s
recipe (description) 20ms 21ms 23ms 39ms 0ms 4.7s
recipe (instructions) 5ms 7ms 7ms 15ms 0ms 3.2s
synthetic (title) 55ms 60ms 76ms 317ms 1400ms 14.4s
synthetic (string inside object) 50ms 52ms 67ms 746ms 1401ms 8.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 43ms 48ms 481ms 859ms 10.7s
article (body) 14ms 16ms 21ms 62ms 392ms 5.4s
article (string inside object) 38ms 40ms 45ms 139ms 325ms 6.7s
article (string inside array) 43ms 47ms 52ms 165ms 418ms 7.3s
recipe (name) 21ms 22ms 24ms 47ms 0ms 7.2s
recipe (description) 19ms 21ms 23ms 48ms 0ms 4.6s
recipe (instructions) 5ms 7ms 11ms 29ms 0ms 3.1s
synthetic (title) 52ms 55ms 59ms 137ms 931ms 14.1s
synthetic (string inside object) 49ms 52ms 56ms 82ms 962ms 8.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

package.json Outdated Show resolved Hide resolved
@RitaDias RitaDias requested review from a team and bjoerge February 7, 2025 08:17
bjoerge
bjoerge previously approved these changes Feb 7, 2025
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RitaDias

@RitaDias RitaDias added this pull request to the merge queue Feb 7, 2025
Merged via the queue into next with commit b3a95e2 Feb 7, 2025
62 checks passed
@RitaDias RitaDias deleted the update-plugin-version branch February 7, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants