Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade vite to v6 #7995

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(deps): upgrade vite to v6 #7995

merged 2 commits into from
Jan 16, 2025

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 9, 2024

Description

Upgrades vite to the latest version (v6), as well as vitest to v3

What to review

Give it a test, see how it feels! Does anything break?
There's a prerelease you can use to test it on a local studio, under the upgrade-vite-v6 branch on npm.

Testing

Commands involved:

  • sanity dev
  • sanity build
  • sanity preview

Notes for release

  • Upgrades vite to version 6

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 5:21pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 5:21pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 5:21pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 5:21pm
test-next-studio ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 5:21pm

Copy link
Contributor

github-actions bot commented Dec 9, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Component Testing Report Updated Jan 16, 2025 5:24 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 0s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 50s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 1s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️ Editor Performance Report

Updated Thu, 16 Jan 2025 17:30:11 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.3 efps (43ms) 20.8 efps (48ms) +5ms (+11.6%)
article (body) 63.5 efps (16ms) 63.1 efps (16ms) +0ms (-/-%)
article (string inside object) 24.4 efps (41ms) 25.6 efps (39ms) -2ms (-4.9%)
article (string inside array) 21.7 efps (46ms) 21.5 efps (47ms) +1ms (+1.1%)
recipe (name) 50.0 efps (20ms) 47.6 efps (21ms) +1ms (+5.0%)
recipe (description) 54.1 efps (19ms) 55.6 efps (18ms) -1ms (-2.7%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.2 efps (55ms) 18.5 efps (54ms) -1ms (-1.8%)
synthetic (string inside object) 19.2 efps (52ms) 19.2 efps (52ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 70ms 81ms 533ms 971ms 11.5s
article (body) 16ms 18ms 21ms 59ms 86ms 5.2s
article (string inside object) 41ms 44ms 46ms 147ms 163ms 7.0s
article (string inside array) 46ms 48ms 55ms 208ms 291ms 7.6s
recipe (name) 20ms 21ms 22ms 32ms 0ms 7.9s
recipe (description) 19ms 20ms 24ms 34ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 11ms 0ms 3.1s
synthetic (title) 55ms 58ms 67ms 332ms 1202ms 13.1s
synthetic (string inside object) 52ms 54ms 62ms 426ms 875ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 48ms 69ms 79ms 510ms 1086ms 12.5s
article (body) 16ms 18ms 21ms 160ms 213ms 5.6s
article (string inside object) 39ms 42ms 49ms 254ms 289ms 7.0s
article (string inside array) 47ms 49ms 54ms 219ms 329ms 7.3s
recipe (name) 21ms 23ms 27ms 50ms 0ms 7.7s
recipe (description) 18ms 19ms 21ms 28ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 10ms 0ms 3.1s
synthetic (title) 54ms 58ms 61ms 316ms 989ms 12.6s
synthetic (string inside object) 52ms 58ms 67ms 417ms 591ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link

socket-security bot commented Jan 13, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
License Policy Violation npm/next@15.1.0
  • License: CC-BY-SA-4.0 - Not allowed by license policy (package/dist/compiled/glob/LICENSE, package/dist/compiled/glob/LICENSE)
⚠︎

View full report↗︎

Next steps

What is a license policy violation?

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/next@15.1.0

bjoerge
bjoerge previously approved these changes Jan 14, 2025
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @rexxars! <3

@rexxars rexxars requested a review from a team as a code owner January 16, 2025 17:07
@rexxars rexxars changed the title fix(deps): upgrade vite to v6 fix(deps): upgrade vite to v6, vitest to v3 Jan 16, 2025
@rexxars rexxars changed the title fix(deps): upgrade vite to v6, vitest to v3 fix(deps): upgrade vite to v6 Jan 16, 2025
@rexxars rexxars merged commit 995eeba into next Jan 16, 2025
48 of 49 checks passed
@rexxars rexxars deleted the upgrade-vite-v6 branch January 16, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants