Repository navigation
fix(deps): update @tanstack/react-virtual to ^3.14.21 - #15559
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
✅ E2E Tests🟢 230 passed • 🟡 3 flaky • (⚪ 93 skipped) • view full report • view run |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
📚 TypeDoc Generation Result✅ TypeDoc generated successfully!
The TypeDoc JSON file has been generated and validated. All documentation scripts completed successfully. |
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (1c6e955) | vs v6.20.0 |
|---|---|---|---|
| Internal (raw) | 4.64 MB | - | +25.6 KB, +0.5% |
| Internal (gzip) | 1.16 MB | - | +8.5 KB, +0.7% |
| Bundled (raw) | 13.76 MB | +12.9 KB, +0.1% | +35.4 KB, +0.3% |
| Bundled (gzip) | 3.27 MB | +3.3 KB, +0.1% | +10.5 KB, +0.3% |
| Import time | 976ms | -1ms, -0.1% | -19ms, -1.9% |
bin:sanity
| Metric | Value | vs main (1c6e955) | vs v6.20.0 |
|---|---|---|---|
| Internal (raw) | 7.1 KB | - | - |
| Internal (gzip) | 2.9 KB | - | - |
| Bundled (raw) | 7.1 KB | - | - |
| Bundled (gzip) | 2.8 KB | - | - |
| Import time | 3ms | +0ms, +2.1% | -0ms, -0.3% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
stipsan
added
the
✨ ai
Cursor
Contributor
Visual regression coverageNo changed UI files ( |
Contributor
Coverage Report
File CoverageNo changed files found. |
cursor
Bot
force-pushed
the
cody/tanstack-react-virtual-3-14-21-60bf
branch
2 times, most recently
from
October 22, 2026 15:23
f03c9fc to
a3c8e78
Compare
Bumps @tanstack/react-virtual ^3.14.19 -> ^3.14.21 (@tanstack/virtual-core 3.19.4 -> 3.19.6) and repairs the jsdom unit tests the bump broke. virtual-core 3.19.6 (TanStack/virtual#1326) measures the scroll viewport with clientWidth/clientHeight instead of offsetWidth/offsetHeight so that borders and scrollbars no longer inflate it. jsdom has no layout engine, so every dimension reads 0 and the virtualizer renders no rows unless the tests stub the dimensions it reads. `setupVirtualListEnv` and the CommandList test only stubbed the offset pair, so every virtualized list under test rendered empty. The stub now covers the client pair too (rows are still measured with offset dimensions), and the CommandList test uses the shared helper instead of its own copy of the stub. pnpm pruned the now-stale `@tanstack/*@<old version>` entries from `minimumReleaseAgeExclude` (`minimumReleaseAgeExcludePrune`). Supersedes #15438.
cursor
Bot
force-pushed
the
cody/tanstack-react-virtual-3-14-21-60bf
branch
from
October 22, 2026 16:24
a3c8e78 to
000e935
Compare
pedrobonamin
approved these changes
Oct 23, 2026
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
@tanstack/react-virtual^3.14.19→^3.14.21(@tanstack/virtual-core3.19.4 → 3.19.6) together with the unit-test fix the bump needs. Supersedes #15438, where the same three unit test shards failed on every rerun.Root cause.
@tanstack/virtual-core3.19.6 (TanStack/virtual#1326) measures the scroll viewport withclientWidth/clientHeightinstead ofoffsetWidth/offsetHeight, so borders and scrollbars no longer inflate it and end-aligned items are not obscured. jsdom has no layout engine, so every element dimension reads 0 and the virtualizer renders no rows unless a test stubs the dimension it reads; our jsdom tests stubbed only the offset pair (the approach TanStack recommended in virtual#641), so with 3.19.6 every virtualized list under test rendered empty (Unable to find an element by: [data-testid="table-row"],[data-testid="button"]). Studio code is not affected: in a real browserclientHeightis non-zero, and the browser-mode and e2e suites were already green on #15438. The tests were relying on an implementation detail of the library.Fix.
test/testUtils/setupVirtualListEnvnow stubsclientWidth/clientHeightin addition tooffsetWidth/offsetHeight(rows are still measured with the offset pair, andCommandListreads it for its hidden-scroll-element check), andCommandList.test.tsxuses that shared helper instead of its own copy of the stub. This is the same adjustment TanStack made to its own jsdom setup in #1326.pnpm installalso pruned the now-stale@tanstack/*@<old version>entries fromminimumReleaseAgeExclude(minimumReleaseAgeExcludePrune: true).What to review
packages/sanity/test/testUtils/setupVirtualListEnv.ts: the stubbed property set and the restore (clientWidth/clientHeightlive onElement.prototypein jsdom, so the shadowingHTMLElement.prototypeproperty is deleted rather than restored from a descriptor).CommandList.test.tsx: the inline stub is replaced bysetupVirtualListEnv(undefined, 800, 800), the same dimensions it used before.Testing
Reproduced the CI failure locally with the bump alone, then with the fix:
CommandList.test.tsx,DocumentTable.test.tsx,ReleaseSummary.test.tsx,ReleasesOverview.test.tsx,VariantDocumentsTable.test.tsx,VariantsOverview.test.tsx(the six suites failing on chore(deps): update dependency @tanstack/react-virtual to ^3.14.21 #15438) all pass.FormBuilder.test.tsxarray itemscases, added tomainafter chore(deps): update dependency @tanstack/react-virtual to ^3.14.21 #15438's last rebase (fix(form): give every field and array item a suspense boundary and warn when a form component suspends #15474), fail with the bump alone and pass with the fix.oxfmt --checkandoxlint(with type checking) on the changed files.Notes for release
N/A: dependency bump and test-only fix.