fix: handle parenthesis directly inside filters

In queries like *[(type == "book")] we didn't properly recurse to determine if it's possible constant evaluate the expression.
sanity-io · Aug 10, 2023 · abe94a9 · abe94a9
1 parent e2b2608
commit abe94a9
Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/evaluator/constantEvaluate.ts b/src/evaluator/constantEvaluate.ts
@@ -6,6 +6,7 @@ import {Scope} from './scope'
 function canConstantEvaluate(node: ExprNode): boolean {
   switch (node.type) {
     case 'Group':
+      return canConstantEvaluate(node.base)
     case 'Value':
     case 'Parameter':
       return true

diff --git a/test/parse.test.ts b/test/parse.test.ts
@@ -201,3 +201,7 @@ t.test('Delta-GROQ', async (t) => {
     })
   }
 })
+
+t.test('handles parenthesis inside filters (regression bug)', async (t) => {
+  t.doesNotThrow(() => parse('*[(_type == "foo")]'))
+})
-Original file line number
+Diff line change
@@ @@ -201,3 +201,7 @@ t.test('Delta-GROQ', async (t) => { @@
         })
       }
     })
+    t.test('handles parenthesis inside filters (regression bug)', async (t) => {
+      t.doesNotThrow(() => parse('*[(_type == "foo")]'))
+    })