fix: Address issues where minimega environment variables are not passed #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommands, impacting restart hard and docker container environments
mitchnegus
reviewed
Sep 8, 2025
mitchnegus
reviewed
Sep 8, 2025
sdelliot
commented
Sep 22, 2025
Co-authored-by: Mitch Negus <[email protected]> Signed-off-by: Steven Elliott <[email protected]>
mitchnegus
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that is most prevalent in Docker environments, but could impact other experiments as well. We enable users to overwrite minimega configuration values via environment variables. However, our
restartcommands are run via SSH on all nodes (via clustershell). Therefore, these variables must be passed to that remote command much in the same way that we pass the python path and GRPC path. This PR addresses resolves this issue.Additionally, this corrects the larger problem of the environment variables not being used properly within the docker environment. That is, user-defined environment variables should be kept even if there are other default values. This fix addresses the issue and ensures that our container adheres to our docker documentation.