option to pickle testcase lock files #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmosby
reviewed
Nov 4, 2025
| generators: set[AbstractTestGenerator] = set() | ||
| for root, paths in self.roots.items(): | ||
| found, e = config.pluginmanager.hook.canary_discover_generators(root=root, paths=paths) | ||
| print(found) |
There was a problem hiding this comment.
Leftover from development? Otherwise should it be logged?
Suggested change
| print(found) |
Comment on lines
+30
to
+47
| delay = 0.5 | ||
| attempt = 0 | ||
| while attempt <= attempts: | ||
| # Guard against race condition when multiple batches are running at once | ||
| attempt += 1 | ||
| try: | ||
| if protocol == JSON: | ||
| with open(file, "r") as fh: | ||
| return json.load(fh) | ||
| else: | ||
| with open(file, "rb") as fh: | ||
| return pickle.load(fh) # nosec B301 | ||
| except Exception: | ||
| time.sleep(delay) | ||
| delay *= 2 | ||
| raise FailedToLoadError( | ||
| f"Failed to load {file.name} after {attempts} {pluralize('attempt', attempts)}" | ||
| ) |
There was a problem hiding this comment.
I feel like this retry pattern is common. Should we establish a retry decorator in utils and use that throughout?
| except json.JSONDecodeError: | ||
| logger.warning(f"Unable to load {file}!") | ||
| continue | ||
| state = serialize.load(file) |
There was a problem hiding this comment.
The previous implies that db might be a database of some sort that provides a (potentially locked/threadsafe) file handle. Should we consider passing the open method to serialize.load, or am I thinking too far ahead given that I don't think that behavior is currently implemented by db.open anyhow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pickle test case lock files. it could be faster?