Skip to content

Conversation

@bartgol
Copy link
Collaborator

@bartgol bartgol commented Sep 23, 2025

A few mods, to avoid code duplication and/or increase readability:

  • create disc/extruded class for extruded disc data structures (they are, or soon will be, growing in number)
  • move side set cell/node numeration maps to base class
  • move creation of kokkos side-sets views from regular sideset structs to base class (can be used by all discs)
  • allow recycling existing dof managers: dof managers really don't care about the fields names, so recyle an existing one if 2 dofs have the same fe type, order, dim and are on same mesh part.Must pass also the state structs (including side set ones)

@bartgol bartgol requested a review from mperego September 23, 2025 22:46
@bartgol bartgol changed the title Change API for the setFieldData method of mesh structs More code cleanup in disc classes. Sep 24, 2025
Copy link
Collaborator

@mperego mperego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Don't you need to modify the MpasSTKMeshStruct as well?
Thanks!

@bartgol
Copy link
Collaborator Author

bartgol commented Sep 29, 2025

It looks good to me. Don't you need to modify the MpasSTKMeshStruct as well? Thanks!

Apparently, MpasSTKMeshStruct does not override setFieldData, and just relies on the impl in GenericSTKMeshStruct.

@bartgol bartgol merged commit b842a5d into master Sep 29, 2025
@bartgol bartgol deleted the bartgol/move-stk-disc-stuff-to-base-class branch September 29, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants