Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupt driven CAN + VatiTACAN nonce resynchronisation #5

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

Stienvdh
Copy link

@Stienvdh Stienvdh commented Apr 4, 2020

No description provided.

Copy link
Member

@jovanbulck jovanbulck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to split up as much as possible. the proposes cst time precaution should go in a separate pull request, but also needs to be fixed as it currently exposes the secret directly. Also no need to rush this, as the current code is constant time but not sure if we ever switch compilers, so let's first try to clean up and integrate vatitacan and then have the constant time code in a seperate PR?

Copy link
Member

@jovanbulck jovanbulck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments :)

@Stienvdh Stienvdh requested a review from jovanbulck April 22, 2020 09:18
Copy link
Member

@jovanbulck jovanbulck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! The code improved a lot and I like how the vatitacan additions in the trusted vatican lib are contained and just and extra phase :) I left some more comments for further improvements. Of course I understand this should not be your priority atm so feel free to look at it whenever you have time ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants