Add EIS control to video stream #11
Conversation
| if (SystemProperties.get("persist.vendor.camera.enableEIS") == "0") { | ||
| Log.i(CameraSession.TAG, "not applying EIS change") | ||
| return; | ||
| } |
There was a problem hiding this comment.
let's always mark end of stream (and return to prev value) so that maybe this solves the crash when video flash is on?
There was a problem hiding this comment.
This actually introduces a fairly annoying edge case. If, due to a crash/edge case, the camera.enableEIS is left as "2" then a new CameraSession won't know which mode to restore to.
I think the neatest solution would be for Foxxconn to offer a new system prop persist.vendor.camera.markEndOfStream which we could toggle between 0 and 1. Then we never have to change the EIS value after boot (until we make it a user setting). Is that possible?
There was a problem hiding this comment.
@lukin87 the way to work around that is for us to introduce our own parent setting called Settings.Global.putInt(contentResolver, "eis_enabled", 0);
(When we make a user setting, this is the one we toggle, not camera.enableEIS)
User toggles that one, RNVC references it but never changes it, and internally handles camera.enableEIS based on that parent setting.
There was a problem hiding this comment.
Ok great! I haven't done global settings yet but I assumed it'd be easy enough. I'll have a play with it now
|
|
||
| fun CameraSession.setEISMode(newMode: String) { | ||
| Log.i(CameraSession.TAG, "EIS: changed from: " + SystemProperties.get("persist.vendor.camera.enableEIS")); | ||
| SystemProperties.set("persist.vendor.camera.enableEIS", newMode); |
There was a problem hiding this comment.
It's possible that the user updates to the LightOS version that runs this code, but they have old firmware (from deferring it, or bugs in the FOTA updater).
So, I believe this whole method needs to be wrapped in a try/catch in the case it's running on an earlier version of the firmware (that doesn't have the SELinux rules allowing us to access this system property)
There was a problem hiding this comment.
Ahhh nice one - good catch.
I've put in a check now. I don't think there's any issue with just failing silently since toggling that bit would have no effect anyways but let me know if I've thought that through wrong
What
Adding in the EIS control flow to RNVC.
Changes
Tested on
Related issues