Skip to content

Commit

Permalink
Guard empty insert_all case
Browse files Browse the repository at this point in the history
  • Loading branch information
sanak committed Aug 26, 2024
1 parent ce4dd4e commit 11b6bfa
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions app/models/member_role.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,20 @@ def add_role_to_subprojects
new_member_attrs << child_member.attributes.except('id')
end
end
new_member_ids = Member.insert_all!(new_member_attrs).to_a.pluck("id")
if new_member_attrs.present?
new_member_ids = Member.insert_all!(new_member_attrs).to_a.pluck("id")
else
new_member_ids = []
end
all_member_ids = existing_member_ids + new_member_ids
member_role_attrs = []
all_member_ids.each do |member_id|
member_role = MemberRole.new(:member_id => member_id, :role_id => role_id, :inherited_from => id)
member_role_attrs << member_role.attributes.except('id')
if all_member_ids.present?
member_role_attrs = []
all_member_ids.each do |member_id|
member_role = MemberRole.new(:member_id => member_id, :role_id => role_id, :inherited_from => id)
member_role_attrs << member_role.attributes.except('id')
end
MemberRole.insert_all!(member_role_attrs)
end
MemberRole.insert_all!(member_role_attrs)
end
end

Expand Down

0 comments on commit 11b6bfa

Please sign in to comment.