chore: add npm version to engines field #734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviall
force-pushed
the
jviall/update-engines-npm
branch
from
5af93f6 to
27c6c8c
Compare
jviall
force-pushed
the
jviall/update-engines-npm
branch
from
27c6c8c to
f84835f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the package.json specifies a minimum node version of 18, it's probably a good idea to also specify the corresponding minimum npm version of 10, which is the version shipped with Node 18 (this will only trigger a warning if consumers for some reason are using an earlier version on npm along with node 18, so no need for a new major version).
With this change, it's also a good idea to delete and rebuild the package-lock.json again with npm v10, which upgrades the lockFileVersion from 2 to 3, the default for npm v10. This mostly just removes redundant info that version 3 optimizes out.
alternatively, you could just update the package-lock without specifying the npm version in engines
@davesnx I defer to you whether this should be a
chore/fix/feat