Skip to content

Bring in the majority of bulkrax guided import#2988

Draft
laritakr wants to merge 6 commits intomainfrom
bulkrax-guided-import
Draft

Bring in the majority of bulkrax guided import#2988
laritakr wants to merge 6 commits intomainfrom
bulkrax-guided-import

Conversation

@laritakr
Copy link
Copy Markdown
Collaborator

@laritakr laritakr commented Mar 26, 2026

Summary

  • Updates Bulkrax
  • Adds a feature flipper to hide Bulkrax's Guided Import feature until it is more fully implemented.

Screenshots

Screenshot 2026-03-23 at 5 29 19 PM
When flipper is on Screenshot 2026-03-23 at 5 29 28 PM Screenshot 2026-03-23 at 5 29 45 PM

@laritakr laritakr added the minor-ver for release notes label Mar 26, 2026
@laritakr laritakr mentioned this pull request Mar 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Test Results

    3 files  ±0      3 suites  ±0   16m 14s ⏱️ +11s
2 314 tests ±0  2 258 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 341 runs  ±0  2 283 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 927d026. ± Comparison against base commit cf5f396.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7a0da12e-3d1e-4eec-9c3a-762fb4de2df0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit d49a8fb2-3ab7-4d4d-b3d7-eb73d9c4387a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ba5e3d5c-b899-4bb8-bda0-920b70502c80
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ab853bed-97ec-4f46-98bf-c6af2a0ad05f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy beed4a1e-34a1-46ff-8d6b-0e87f7b84cbb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 196070b8-c280-4405-a85b-d3b08c510f0c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read b3262370-df40-45fa-a1c1-2098805c2b77
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update da4544eb-b660-44b5-bf09-955a45840ed0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ede6579d-bdf6-4f0f-86bd-d96f0955f51c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 42ca2578-34ad-4fb4-bcf1-ad25f676669e
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy de0d1b68-2f79-457b-ac35-433342c2303b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 10e75e4c-d7ed-466a-9778-7afdb8767c7e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read aedf84dd-7e23-4fd4-b83b-efeae9871704
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update e86ca170-d62a-42a0-8b41-75dc6490547b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy f1b98af7-492c-4d1b-bdd6-1f64a51f3e71
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit b6e903bd-ce67-461c-bad6-a3064c497e55
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read e2158392-52d7-41eb-a167-0e7ad9de9395
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update ebc66634-8f8c-44d4-b4b4-0b933fed12a3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a17f4eda-9e2f-41c9-a059-80d020b25cea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5b324260-d40f-4bdc-90d6-1fad8e526926
…

♻️ This comment has been updated with latest results.

The fix uses a savepoint (requires_new: true) so that if Flipflop.include_guided_import? fails with a StatementInvalid (because hyrax_features doesn't exist yet in a brand-new schema), only the savepoint is rolled back — the outer Apartment::Tenant.create transaction continues unharmed.

In production this never triggers since the table always exists by the time any request is processed. In tests during Apartment::Tenant.create, the savepoint cleanly handles the missing table and returns false, allowing tenant creation to complete.
Fixes lint error and pulls in most recent bulkrax
guided import code.
The fix we needed has been merged into that branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor-ver for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant