Bring in the majority of bulkrax guided import#2988
Draft
Conversation
Closed
Test Results 3 files ±0 3 suites ±0 16m 14s ⏱️ +11s Results for commit 927d026. ± Comparison against base commit cf5f396. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The fix uses a savepoint (requires_new: true) so that if Flipflop.include_guided_import? fails with a StatementInvalid (because hyrax_features doesn't exist yet in a brand-new schema), only the savepoint is rolled back — the outer Apartment::Tenant.create transaction continues unharmed. In production this never triggers since the table always exists by the time any request is processed. In tests during Apartment::Tenant.create, the savepoint cleanly handles the missing table and returns false, allowing tenant creation to complete.
Fixes lint error and pulls in most recent bulkrax guided import code.
The fix we needed has been merged into that branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
When flipper is on