Skip to content

Fix visibility form collapse/expand for batches #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hortongn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix visibility form collapse/expand for batches #3171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/views/sufia/batch_uploads/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<%= simple_form_for [sufia, @form], html: { multipart: true } do |f| %>
<%= simple_form_for [sufia, @form],
html: {
data: { behavior: 'work-form' },
multipart: true
} do |f| %>
<% content_for :files_tab do %>
<p class="switch-upload-type">To create a single work for all the files, go to <%= link_to "New Work", [:new, Sufia.primary_work_type.model_name.singular_route_key] %></p>
<p class="instructions"><%= t("sufia.batch_uploads.files.instructions") %></p>
Expand Down
1 change: 1 addition & 0 deletions spec/views/sufia/batch_uploads/_form.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

it "draws the page" do
expect(page).to have_selector("form[action='/batch_uploads']")
expect(page).to have_selector("form[action='/batch_uploads'][data-behavior='work-form']")
# No title, because it's captured per file (e.g. Display label)
expect(page).not_to have_selector("input#generic_work_title")
expect(view.content_for(:files_tab)).to have_link("New Work", href: "/concern/generic_works/new")
Expand Down