refactor(ui): ensure ui-confirm can be used in controlled mode #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
samui-wallet-web | 3a5bc56 | Commit Preview URL Branch Preview URL |
Dec 16 2025, 09:17 AM |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 3d862f6 in 56 seconds. Click for details.
- Reviewed
258lines of code in8files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/explorer/src/ui/explorer-ui-bookmark-account-table.tsx:67
- Draft comment:
Good refactor—using the trigger prop instead of children in UiConfirm aligns with the updated API. Verify that this controlled/uncontrolled behavior works as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/explorer/src/ui/explorer-ui-bookmark-transaction-table.tsx:67
- Draft comment:
The refactor to use the trigger prop for UiConfirm is consistent here as well. Confirm that the controlled mode toggle (if needed) remains functional. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. packages/settings/src/settings-feature-general-danger-delete-database.tsx:30
- Draft comment:
The async action passed to UiConfirm handles database reset but lacks error handling. Consider wrapping the async call in a try/catch block to manage potential failures. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. packages/ui/src/components/ui-confirm.tsx:41
- Draft comment:
The onClick handler on AlertDialogAction directly calls the async action. Although acceptable for inline callbacks, consider wrapping the call in a try/catch to guard against unhandled promise rejections. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_41W1nJCn26PCplb1
You can customize 
BundleMonFiles updated (6)
Unchanged files (92)
Total files change -274.47KB -25.02% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
tobeycodes
approved these changes
Dec 15, 2025
beeman
force-pushed
the
beeman/ui-bottom-sheet-controlled
branch
from
e6a0c15 to
17351ae
Compare
beeman
force-pushed
the
beeman/ui-confirm-controlled
branch
from
3d862f6 to
aaec062
Compare
beeman
force-pushed
the
beeman/ui-confirm-controlled
branch
from
aaec062 to
3a5bc56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the
UiConfirmcomponent so it can be used controlled and uncontrolled, and moves theopenstate next to the button in 2 places.This is in preparation for #736 where we want to be able to trigger these sheets from a dropdown menu.
Important
Refactor
UiConfirmto support controlled mode and update its usage across components with a newtriggerprop.UiConfirminui-confirm.tsxto support controlled and uncontrolled modes using a newtriggerprop.ExplorerUiBookmarkAccountTableandExplorerUiBookmarkTransactionTableto usetriggerprop forUiConfirm.SettingsFeatureGeneralDangerDeleteDatabaseto usetriggerprop forUiConfirm.SettingsUiNetworkDeleteConfirmandSettingsUiWalletDeleteConfirmto handle network and wallet deletions withUiConfirm.UiConfirmusage withSettingsUiNetworkDeleteConfirminsettings-ui-network-list-item.tsx.UiConfirmusage withSettingsUiWalletDeleteConfirminsettings-ui-wallet-list-item.tsx.This description was created by
for 3d862f6. You can customize this summary. It will automatically update as commits are pushed.