refactor(ui): change the ui-bottom-sheet to a controlled component #766
+148
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ⛔ Deployment terminated View logs |
samui-wallet-web | 17351ae | Commit Preview URL Branch Preview URL |
Dec 16 2025, 09:29 AM |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e6a0c15 in 48 seconds. Click for details.
- Reviewed
305lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/settings/src/ui/settings-ui-export-account-secret-key-sheet.tsx:33
- Draft comment:
Good use of the ternary operator for conditional rendering. Ensure that checking readSecretKeyMutation?.data?.length correctly handles cases where an empty string might be valid. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. packages/settings/src/ui/settings-ui-export-account-secret-key.tsx:8
- Draft comment:
The refactored export component now lifts the open state and cleanly separates the trigger from the bottom sheet. This approach is clear and aligns with best practices. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. packages/settings/src/ui/settings-ui-export-wallet-mnemonic-sheet.tsx:33
- Draft comment:
The controlled bottom sheet for wallet mnemonic export is well implemented. Verify that the condition (readMnemonicMutation.data?.length) meets the intended behavior, especially if an empty string might occur. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. packages/settings/src/ui/settings-ui-export-wallet-mnemonic.tsx:8
- Draft comment:
The wallet mnemonic export component correctly adopts a controlled pattern by using a Fragment to group the trigger button and the sheet. This implementation looks good. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. packages/ui/src/components/ui-bottom-sheet.tsx:9
- Draft comment:
The UiBottomSheet component now leverages a spread of props and removes the trigger prop. This provides better control, so ensure that all consumers have been updated accordingly and consider updating documentation if needed. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_URGFAUrP4Nr99SW6
You can customize 
BundleMonFiles updated (6)
Unchanged files (92)
Total files change +249.1KB +29.38% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
tobeycodes
approved these changes
Dec 15, 2025
beeman
force-pushed
the
beeman/remove-accounts
branch
from
071cde4 to
3d4c35b
Compare
beeman
force-pushed
the
beeman/ui-bottom-sheet-controlled
branch
from
e6a0c15 to
17351ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the
UiBottomSheetcomponent controlled and moves theopenstate next to the button.This is in preparation for #736 where we want to be able to trigger these sheets from a dropdown menu.
Important
Refactor
UiBottomSheetto be a controlled component and update related components to manageopenstate externally.UiBottomSheetinui-bottom-sheet.tsxto be a controlled component by removingtriggerprop and addingonOpenChangeandopenprops.SettingsUiExportAccountSecretKeyandSettingsUiExportWalletMnemonicto manageopenstate and pass it toUiBottomSheet.SettingsUiExportAccountSecretKeySheetandSettingsUiExportWalletMnemonicSheetto encapsulate bottom sheet logic for account secret key and wallet mnemonic, respectively.openstate management toSettingsUiExportAccountSecretKeyandSettingsUiExportWalletMnemoniccomponents.This description was created by
for e6a0c15. You can customize this summary. It will automatically update as commits are pushed.