feat: ensure deleting wallet deletes connected accounts #765
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
samui-wallet-web | 071cde4 | Commit Preview URL Branch Preview URL |
Dec 14 2025, 01:57 PM |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 071cde4 in 41 seconds. Click for details.
- Reviewed
65lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/db/src/wallet/wallet-delete.ts:10
- Draft comment:
Consider using a dedicated error logging method (e.g. console.error or a logging library) instead of console.log for error logging. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. packages/db/src/wallet/wallet-delete.ts:18
- Draft comment:
The function signature promises to return void but returns 'data' from the deletion. Consider explicitly returning void for consistency. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. packages/db/test/wallet-delete.test.ts:33
- Draft comment:
A test case for failure in account deletion (bulkDelete) could be added to fully validate error handling when connected accounts fail to delete. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_ixbHo5NtLkq8YrDM
You can customize 
BundleMonFiles updated (4)
Unchanged files (94)
Total files change -854B -0.1% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
tobeycodes
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wallet delete now deletes all the linked accounts.
Closes #746
Checklist
Important
walletDeletenow deletes linked accounts before deleting a wallet, with tests added to verify this behavior.walletDeleteinwallet-delete.tsnow deletes all accounts linked to a wallet before deleting the wallet itself.wallet-delete.test.tsto verify accounts are deleted when a wallet is deleted.This description was created by
for 071cde4. You can customize this summary. It will automatically update as commits are pushed.