feat(db): ensure we have a runtime check to see if network type is valid #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
samui-wallet-api | cab26b0 | Commit Preview URL Branch Preview URL |
Dec 14 2025, 01:26 PM |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to cab26b0 in 43 seconds. Click for details.
- Reviewed
50lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/db/src/network/network-create.ts:7
- Draft comment:
The removed TODO comment indicates that network type validation is now handled by the schema (via networkCreateSchema.parse). Consider adding a clarifying comment to document that runtime validation (including valid network type) is performed here. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. packages/db/test/network-create.test.ts:165
- Draft comment:
Good addition of a test case for an invalid network type using an inline snapshot. This reinforces that only allowed types are accepted by the schema. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_BVHn0IAFQ6t7FUmI
You can customize 
BundleMonUnchanged files (98)
No change in files bundle size Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
tobeycodes
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a todo and assures this works by adding a test.
Important
Removes TODO and adds test to ensure
networkCreatethrows error for invalid network type.networkCreatefunction innetwork-create.tsregarding runtime check for valid network type.network-create.test.tsto ensurenetworkCreatethrows an error for invalid network typesolana:custom.networkCreaterejects invalid network types with a specific error message using Zod validation.This description was created by
for cab26b0. You can customize this summary. It will automatically update as commits are pushed.