feat(dev): add dev playground for multiple address input #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
samui-wallet-web | 79fef3c | Commit Preview URL Branch Preview URL |
Dec 16 2025, 12:36 PM |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 3a6d831 in 2 minutes and 3 seconds. Click for details.
- Reviewed
226lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/dev/src/dev-feature-ui-inputs-solana-addresses.tsx:52
- Draft comment:
The remove button has a redundant disabled check (disabled={index === 0}) though it’s conditionally not rendered when index is 0. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_HFIGhuC0prZ4PhKE
You can customize 
| ))} | ||
| <div className="flex justify-end space-x-2"> | ||
| <Button | ||
| disabled={fields.length > 9 && !form.formState.isValid} |
There was a problem hiding this comment.
The disabled condition on the append button uses an AND (&&) which may allow adding more addresses when the form is valid. Likely, it should use OR (||) so the button disables if count > 9 regardless of form validity.
Suggested change
| disabled={fields.length > 9 && !form.formState.isValid} | |
| disabled={fields.length > 9 || !form.formState.isValid} |
beeman
force-pushed
the
beeman/multiple-addresses
branch
from
3a6d831 to
849957e
Compare
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed 849957e in 2 minutes and 6 seconds. Click for details.
- Reviewed
226lines of code in5files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/dev/src/dev-feature-ui-inputs-solana-address.tsx:18
- Draft comment:
Good use of function declaration and ternary operator for conditional rendering. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/dev/src/dev-feature-ui-inputs.tsx:5
- Draft comment:
Component composition using function declaration is clear and well-structured. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. packages/dev/src/dev-feature-ui.tsx:6
- Draft comment:
Main DevFeatureUi component correctly uses a function declaration and composes its child components. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. packages/ui/src/components/ui-icon-map.tsx:27
- Draft comment:
New 'minus' icon mapping added correctly to the icon map. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_1BLrqxXbXgyZJ2gi
You can customize
beeman
force-pushed
the
beeman/multiple-addresses
branch
from
849957e to
665188a
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 665188a in 1 minute and 6 seconds. Click for details.
- Reviewed
220lines of code in5files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/dev/src/dev-feature-ui-inputs-solana-address.tsx:18
- Draft comment:
Good use of a function declaration for the top-level React component. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/dev/src/dev-feature-ui-inputs-solana-addresses.tsx:51
- Draft comment:
The removal button is conditionally hidden for the first address (index === 0). Confirm this is the intended behavior to always keep at least one address visible. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. packages/dev/src/dev-feature-ui-inputs-solana-addresses.tsx:66
- Draft comment:
The add button is disabled when fields.length > 9, effectively limiting the input count. Consider using a named constant (e.g., MAX_ADDRESSES) for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. packages/dev/src/dev-feature-ui-inputs.tsx:5
- Draft comment:
Component composition is clear; using a function declaration for the top-level component is a good practice. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. packages/dev/src/dev-feature-ui.tsx:6
- Draft comment:
Consistent use of function declaration for the top-level component. No issues found. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. packages/ui/src/components/ui-icon-map.tsx:127
- Draft comment:
The 'minus' icon mapping is correctly added and consistent with the UiIconName union. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_R93MZtO1ENrJE16F
You can customize
beeman
force-pushed
the
beeman/multiple-addresses
branch
from
665188a to
79fef3c
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 79fef3c in 1 minute and 14 seconds. Click for details.
- Reviewed
289lines of code in10files - Skipped
0files when reviewing. - Skipped posting
8draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/dev/package.json:7
- Draft comment:
Dependency on '@workspace/i18n' is added—ensure it’s aligned with the intended usage in your dev features. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/dev/src/dev-feature-ui-inputs-solana-address.tsx:18
- Draft comment:
Good use of a function declaration for the top-level component and proper ternary rendering. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. packages/dev/src/dev-feature-ui-inputs-solana-addresses.tsx:54
- Draft comment:
Removal button is disabled for the first address (index === 0); verify this business logic is intentional. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. packages/dev/src/dev-feature-ui-inputs.tsx:5
- Draft comment:
Component 'DevFeatureUiInputs' correctly groups the Solana address input components using a function declaration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. packages/dev/src/dev-feature-ui.tsx:6
- Draft comment:
Top-level component 'DevFeatureUi' is defined as a function declaration, which meets the project guidelines. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. packages/i18n/locales/en/ui.json:2
- Draft comment:
New translation keys ('actionAdd', 'actionRemove', 'actionSave') are added; ensure consistency with other locales. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. packages/i18n/locales/es/ui.json:2
- Draft comment:
New translation keys ('actionAdd', 'actionRemove', 'actionSave') are added; verify the translations match the intended meanings. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. packages/ui/src/components/ui-icon-map.tsx:144
- Draft comment:
Mapping for the 'x' icon is correctly added. The top-level helper functions use proper function declarations. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_AjyBEvDdQxLAXVj5
You can customize
BundleMonFiles updated (9)
Unchanged files (92)
Total files change -37.25KB -4.33% Groups updated (3)
Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds some screens to have a reference on how to do multiple inputs with Solana address validation.
Screenshots / Video
Important
Add Solana address input components with validation and update i18n and UI icon map.
DevFeatureUiInputsSolanaAddressandDevFeatureUiInputsSolanaAddressescomponents for Solana address input with validation indev-feature-ui-inputs-solana-address.tsxanddev-feature-ui-inputs-solana-addresses.tsx.DevFeatureUiInputsindev-feature-ui-inputs.tsxandDevFeatureUiindev-feature-ui.tsx.actionAdd,actionRemove, andactionSaveinen/ui.jsonandes/ui.json.resources.d.tsto include new UI actions.xicon toui-icon-map.tsxfor use in address removal functionality.@workspace/i18ntodependenciesinpackage.json.This description was created by
for 79fef3c. You can customize this summary. It will automatically update as commits are pushed.