🔊 Add info about one reason for RuntimeError, which is otherwise difficult to catch#149
Closed
tiangolo wants to merge 2 commits intosamuelcolvin:mainfrom
tiangolo:multiline-assert
Closed
🔊 Add info about one reason for RuntimeError, which is otherwise difficult to catch#149tiangolo wants to merge 2 commits intosamuelcolvin:mainfrom tiangolo:multiline-assert
RuntimeError, which is otherwise difficult to catch#149tiangolo wants to merge 2 commits intosamuelcolvin:mainfrom
tiangolo:multiline-assert
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 8 8
Lines 729 729
Branches 111 111
=======================================
Hits 702 702
Misses 21 21
Partials 6 6
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔊 Add info about one reason for
RuntimeError, which is otherwise difficult to catchWhen there's a multiline error message in an assert,
insert_assertcan't find the frame, probably a quirk of Python. This adds a message showing what might be the problem.Here's an example test that breaks with the
RuntimeError:The new error will show: