-
Notifications
You must be signed in to change notification settings - Fork 8
Add Table #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Table #8
Conversation
|
||
componentDidMount(){ | ||
const node = React.findDOMNode(this); | ||
mdl.upgradeElement(node); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't upgradeElement need something like 'MaterialTable'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes. It's MaterialDataTable
Maybe this should have separate elements, like suggested in the Tabs PR. It doesn't do anything special with the insides of the table, so maybe we can just inject |
Material-ui originally went with a Table component that just had like over nine thousand configuration options for their initial version. However they split that up into a bunch of components that represent parts of a table ( |
There are some optional classes on table data cells, such as |
@coderhaoxin I think we should have separate components for rows, columns, etc |
done |
I think the mapping needs to go away. A component library should just accept children, not custom DSLs of arrays of objects. |
No description provided.