Fix block and proc definition to work with Ruby 3.0 - #39
Open
JHK wants to merge 3 commits into
Open
Conversation
|
I think this one you missed: |
Owner
|
Do tests pass for you? I get: I had a number of issues getting the tests to run, and need to repair the gemspec. Look out for that if that's helpful |
Author
|
With the Gemfile in the current project the tests don't work for me. Updating some gems and bundler itself worked. I had a successful test run with this patch: Wasn't sure if I should include the Gemfile.lock patch into this PR. Here would be the diff: diff --git a/Gemfile.lock b/Gemfile.lock
index 4810802..995f27a 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
- arachnid2 (0.3.9)
+ arachnid2 (0.4.0)
addressable
adomain
bloomfilter-rb
@@ -16,28 +16,28 @@ GEM
specs:
addressable (2.7.0)
public_suffix (>= 2.0.2, < 5.0)
- adomain (0.2.3)
+ adomain (0.2.4)
addressable (~> 2.5)
logger
bloomfilter-rb (2.1.1)
redis
childprocess (3.0.0)
diff-lcs (1.3)
- ethon (0.12.0)
- ffi (>= 1.3.0)
+ ethon (0.14.0)
+ ffi (>= 1.15.0)
facets (3.1.0)
- ffi (1.12.2)
- json (2.3.0)
- logger (1.4.2)
- mini_portile2 (2.4.0)
- nokogiri (1.10.9)
- mini_portile2 (~> 2.4.0)
- os (1.0.1)
- psych (3.1.0)
- public_suffix (4.0.3)
+ ffi (1.15.0)
+ json (2.5.1)
+ logger (1.4.3)
+ nokogiri (1.11.3-x86_64-darwin)
+ racc (~> 1.4)
+ os (1.1.1)
+ psych (3.3.1)
+ public_suffix (4.0.6)
+ racc (1.5.2)
rake (13.0.1)
- redis (4.1.3)
- regexp_parser (1.7.0)
+ redis (4.2.5)
+ regexp_parser (2.1.1)
rspec (3.8.0)
rspec-core (~> 3.8.0)
rspec-expectations (~> 3.8.0)
@@ -51,22 +51,22 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.8.0)
rspec-support (3.8.0)
- rubyzip (2.2.0)
+ rubyzip (2.3.0)
selenium-webdriver (3.142.7)
childprocess (>= 0.5, < 4.0)
rubyzip (>= 1.2.2)
- typhoeus (1.3.1)
+ typhoeus (1.4.0)
ethon (>= 0.9.0)
- watir (6.16.5)
- regexp_parser (~> 1.2)
- selenium-webdriver (~> 3.6)
- webdriver-user-agent (7.6)
+ watir (6.19.1)
+ regexp_parser (>= 1.2, < 3)
+ selenium-webdriver (>= 3.142.7)
+ webdriver-user-agent (7.8)
facets
json
os
psych
selenium-webdriver (>= 3.4.0)
- webdrivers (4.2.0)
+ webdrivers (4.6.0)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (>= 3.0, < 4.0)
@@ -81,4 +81,4 @@ DEPENDENCIES
rspec (~> 3.0)
BUNDLED WITH
- 1.17.3
+ 2.2.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the following warning in Ruby 2.7, which will become breaking in 3.0: