fixes preventing compilation on mac #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkravitz
reviewed
Feb 16, 2022
| inline s8 signum(double val) | ||
| { | ||
| if(std::isnan(val)) throw std::invalid_argument("Invalid argument passed to util::signum"); | ||
| if(val != val) throw std::invalid_argument("Invalid argument passed to util::signum"); |
Owner
There was a problem hiding this comment.
val != val will never be true, so this check should probably be deleted
samkravitz
reviewed
Feb 16, 2022
| running = false; | ||
| break; | ||
| case SDL_KEYDOWN: [[fallthrough]] | ||
| case SDL_KEYDOWN: [[fallthrough]]; |
Owner
There was a problem hiding this comment.
This is not the only [[fallthrough]] statement in the codebase. Is only this one broken on Mac?
Collaborator
Author
There was a problem hiding this comment.
Yeah, all the other fallthroughs I took a look at have semicolons after actually (though I didn't look at all of them).. not sure how it was compiling without it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.