Skip to content

keybridge: per-host ports for kmip #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Jul 18, 2025

When specifying the KMIP servers to use allow setting custom ports via syntax like:

  • hostname.example.com:9876
  • 192.168.76.81:9876
  • [2001:db8::cafe]:9876

In addition to un-decorated host names. If the port is not specified a default kmip port will be used (and is thus required unless all hosts specify a port).

I read the tea leaves

Add helper properties that extract the port from "hostname" fields (it's
mostly internal - I'm not renaming it now).
Take some care not to break on ipv6 addresses w/o ports.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn phlogistonjohn changed the title WIP: keybridge: per-host ports keybridge: per-host ports for kmip Jul 18, 2025
@phlogistonjohn phlogistonjohn marked this pull request as ready for review July 18, 2025 18:45
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 9facbe3 into samba-in-kubernetes:master Jul 21, 2025
10 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-keybridge branch July 21, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants