keybridge: per-host ports for kmip #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
force-pushed
the
jjm-keybridge
branch
from
99257bc to
1ceefe0
Compare
Add helper properties that extract the port from "hostname" fields (it's mostly internal - I'm not renaming it now). Take some care not to break on ipv6 addresses w/o ports. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-keybridge
branch
from
1ceefe0 to
77b00b2
Compare
phlogistonjohn
changed the title
phlogistonjohn
requested review from
gd,
spuiuk,
anoopcs9,
synarete and
avanthakkar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying the KMIP servers to use allow setting custom ports via syntax like:
hostname.example.com:9876192.168.76.81:9876[2001:db8::cafe]:9876In addition to un-decorated host names. If the port is not specified a default kmip port will be used (and is thus required unless all hosts specify a port).
I read the tea leaves